Andreas Fabri

Results 468 comments of Andreas Fabri

Just my two cents, it would be good to see a higher level CGAL algorithm than `copy_face_graph()` as a motivation.

The questions is if it has measurable impact on Mesh_3, Constrained_triangulation_2, Arrangement_2......

There is nothing to do for the Profile counters. They use `tbb::atomic` and a `tbb::concurrent_hash_map`. To require TBB in order to profile across several threads is acceptable.

@sloriot Can you please check and tick.

@lrineau suggested to make the counter inside the static variable atomic, so that we profile across all threads, assuming that we want the total number of, say filter failures of...

Looking at the code of the [`Histogram_counter`](https://github.com/CGAL/cgal/blob/master/Profiling_tools/include/CGAL/Profile_counter.h#L126) it seems that what you suggest is already implemented. @sloriot and @lrineau : Do I miss something?

The `Histogram_profiler` is not documented, and the fact that it only works across several threads when TBB is available that seems good enough for the moment. Do you agree @sloriot...

I have read the above discussion and I had a look at the code. Can you please answer the following two questions: Do you agree that we want a global...

And do you confirm that we first have to write into a string?

Have a look at the destructor of the [`Histogram_counter`](https://github.com/CGAL/cgal/blob/master/Profiling_tools/include/CGAL/Profile_counter.h#L146). There are many `operator