Alberto Escolar

Results 52 comments of Alberto Escolar

@keith-packard @cfriedt Limiting this check to only some paths would reduce the number of false positives, but the check would still not be correct. The thing is, this check is...

@cfriedt > @aescolar - can you list the legitimate reasons? At least: * Any core/kernel or on tree component which uses an API which is not exposed by default by...

> To clarify, what are the legitimate reasons we would want to allow `_POSIX_C_SOURCE` definitions to be used by "core" parts of Zephyr such as the kernel? > > You...

@cfriedt Those 3 functions and many other are not OS related, but provided by the basic C library without any OS awareness. Many of those have, over the years, been...

@cfriedt Please note: > 1. Mitigate the layering violations with strnlen( Those functions are not OS dependant, and are provided directly by the C libraries. So there is no layer...

@cfriedt > Strnlen and strtok_r are OS independent (correct) but again, there very much is a layering violation at the interface level. Not really. In that drawing you pasted you...

Thanks for the input @bjarki-trackunit > I expect all "standard" (notice the quotes) C functions.. We are trying to close on that topic in https://github.com/zephyrproject-rtos/zephyr/issues/68278, but in very short: quite...

Hi @keith-zephyr, unfortunately this PR has been blocked now for more than a month. As assignee to the PR and owner of the process, I would request you to consider...

@henrikbrixandersen it seems that for some reason coverity thinks the size of sizeof(struct modem_cmux) in modem_cellular.c (288) is different than in modem_cmux.c (292). I have the impression coverity has a...

> @aescolar Thanks. So you agree this looks like a false positive? I think so.