Ammar Yasser

Results 99 comments of Ammar Yasser

@vladikr Thank you, yeah you are right This isn't one pull request though, this includes commits from #1217 and #1230 and those two have to be merged first This PR...

@brianmcarey Valid concerns for sure, let me discuss them > Overall, I am not convinced of the resources that this will save as we will just be running the kubernetes...

@brianmcarey > We do use the control plane node (node01) for scheduling test workloads so I am not sure if the resources are wasted. node01 is schedulable. For instance here...

> Hi @aerosouund - can you provide proof manifests and add tests? @realshuting Absolutely, but there's a small question I went to add unit tests but found that the entire...

@MariamFahmy98 Indeed, I would be happy to work on that as well once we have agreed on how we want to test this It's probably commented out because the current...

@realshuting The test is not valid and i changed its result to check for a nil error. the reason is that this change is for the CLI. and in all...

@dhiller @brianmcarey I can look at this. But if its too urgent i may leave it. since i am a bit tight on time these days so i don't want...

@orelmisan Can you please share the manifests needed for deploying Multus V4 ? (if they have been created yet)

@orelmisan Yes. but it does so through the larger CNAO manifest. I gather from your requirements that you want a dedicated manifest for deploy Multus V4 ONLY similar to how...