Ammar Yasser

Hello @resnostyle Can you please resolve the merge conflicts so we can address this PR ? thanks in advance!

cc: @dhiller @brianmcarey @xpivarc @acardace

@dhiller all points addressed :) please take a look again and let me know p.s: i swapped the implementation of copy remote file to an implementation based on `github.com/bramvdbogaerde/go-scp`. The...

@brianmcarey thats a valid point for sure, can you tell me what are these performance jobs that might be sensitive to the change ? i want to measure the impact...

@brianmcarey @xpivarc it seems that (according to my very limited understanding about that part of kubevirt) that we mainly depend on just two metrics, and these metrics are generated by...

@brianmcarey this failure might have been because I updated the go version locally, I reverted it to 1.21. but locally my toolchain is 1.22.3 and I believe some packages actually...

its still trying to download 1.22 for some reason ``` CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags "-X 'kubevirt.io/kubevirtci/cluster-provision/gocli/images.SUFFIX=:'" -o /home/prow/go/src/github.com/kubevirt/kubevirtci/cluster-provision/gocli/build/cli ./cmd/cli go: downloading go1.22.3 (linux/amd64) go: download go1.22.3: golang.org/[email protected]: verifying...

@brianmcarey @xpivarc Detected the issue on a machine with no go 1.22 Some packages that require 1.22 explicitly in vendor/modules.txt made the go toolchain upgrade itself while downloading the dependencies...

Not fully sure as well, it might just be that the gosumdb is off, on all machines i managed to compile this on it had `GOSUMDB='sum.golang.org'` is there any reason...

@brianmcarey I have verified that not using gosumdb was the problem, i have added it to the makefile and fixed the merge conflict from my perspective.. i don't know why...