adrtivv

Results 8 comments of adrtivv

ahh i was fixing some formatting, anyway you can fix the minor details

> Can you add tests for the types? We use tsd. Not free right now, will try later.

@mcollina The test logic seems to be incorrect [here](https://github.com/mercurius-js/mercurius/blob/0c7a426085aaeac8f66528c71f645878e701f88f/test/types/index.ts#L401): ![1](https://github.com/user-attachments/assets/b107f670-2fc2-4ff1-a766-83ea38045c22)

> @adrtivv why? What's the problem? (it might be) The `publish` and `subscribe` methods are meant to take in generics of type `string` or custom types that extend type `string`....

@mcollina the test is failing because of problems unrelated to this pull request

Enum types for scalars like `CountryCode` as well.

@alisonjenkins i personally don't find anything problematic with your wording but it could come off as accusatory to some people, you just needed to be a bit more technically accurate...