Alexander Droste

Results 23 comments of Alexander Droste

Same here. It's definitely a regression bug to revert to the annotation. Stupid question, why not set both? (Annotation + ingressClassName)

If the goal is to get rid of PortAudio then the fix should be to don't define "HavePortaudio" on Darwin. However, PortaudioInput+PortaudioPlayback and SDLInput+SDLPlayback work fine, mixing them breaks things...

@kanhaiya-2000 Of course, the middleware is called before the connection event is fired. Otherwise you wouldn't be able to handle something like authentication upfront. You cannot move the disconnect register...

@darrachequesne But then, the socket.connected property shouldn't be true when the middleware is called. Nevertheless, it is not a definition problem. The problem here is: how to handle or detect...

@kkleap If you use the middleware to trigger a side effect, you sometimes need to trigger a cleanup for that effect after the client has disconnected. Proper example: Server ```js...

Sure. It's definitely a bug in Preview. Nevertheless, it can easily be fixed by changing every box-shadow to a drop-shadow. It's a fast and easy change and it won't make...

@Gazook89 Descriptive text boxes also have a white-ish box shadow: `box-shadow: 0 0 6px #faf7ea;`

@calculuschild Did some further research and it's true, the drop-shadow works because chrome will print the box as an image with transparency. This reduces the visual quality of the text...

The shadow must just be applied at another level. It must not be via ::before or ::after. It can be any element anywhere as long as you keep track of...

Absolutely. I just looked at #2127. If it's just about these 4 places, it should be fairly easy to implement and test: - The before pseudo element is not used...