Adrian Price-Whelan

Results 101 issues of Adrian Price-Whelan

Not sure about the specifics here, but conceptually: Since the PSP will now allow a ~NaN~None time, we should error early if we know that ~NaN~None is going to get...

The potential, orbit, and phasespaceposition objects should continue to have `.plot_thing()` methods, but the methods should accept a `backend="..."` argument to dispatch to different plot libraries. We can start with...

A time value can be attached to a PhaseSpacePosition and acts like additional metadata that is carried along. In the future, we may want to generalize this to support tracking...

As we discussed on the call, this would enable making any spherical potential a triaxial model (in the potential). API to be worked out, but the idea would be to...

For example, draft API from my past thinking about things we could support: ```python sim = Simulation(external_potential=..., extra_forces=[ChandrasekharDynamicalFriction(...), ...]) p1 = ParticleCollection(PhaseSpacePosition(...), potential=..., name="Milky Way") sim.add_particle(p1) p2 = ParticleCollection(PhaseSpacePosition(...), potential=...,...

@adrn has an implementation of these, so will move them over for v0.1!

Some possible use cases / integration tests: - Bar spinning (simulation in inertial frame) - Halo figure rotation w.r.t. static disk (simulation in inertial frame) - Simulation in a rotating...

documentation

In a change from Gala's behavior, the galax potential classes should not allow dimensionless unit systems. Instead, we should make it easier for users to create explicit unit systems to...

Hello! I have a custom multi-dimensional distribution where the support may be truncated along some dimensions. In terms of constraints, some dimensions will either be `real`, `greater_than`, `less_than`, or `interval`....

enhancement
good first issue