Adrian Ludwin
Adrian Ludwin
Understood, but the actual code ([here](https://github.com/kubernetes-sigs/cli-utils/blob/3f2bc6abd1902c41edf284c7a6e62dc10d13664b/pkg/kstatus/status/generic.go#L50) and [here](https://github.com/kubernetes-sigs/cli-utils/blob/3f2bc6abd1902c41edf284c7a6e62dc10d13664b/pkg/kstatus/status/status.go#L153)) seems to ignore any condition except one of those three (except for K8s built-in objects). Anyway, I'd be in favour of adding...
Yes, each reason has exactly one condition type, so I believe they could be removed. The bigger problem is that some of these conditions are basically warnings, and others are...
... with all that said, _adding_ all this to the existing API sgtm, and then when we next bump the API to v1beta1, we can drop the custom fields.
lgtm after these last changes are made. Ryan, please feel free to approve (or else I'll do it). /assign @rjbez17
Sorry for the delay in getting back to you. Does Crossplane put any labels or annotations on the objects it inserts into your namespaces? If so, we could extend K8s...
... we could also make this configurable, it's always been easier not to though until now :/
I'm afraid I don't really know anything about Crossplane and don't have time to look into it. I do think the fix would be fairly easy if Crossplane (or its...
Cool, thanks! On Mon, Apr 25, 2022 at 1:05 PM Ryan Bezdicek ***@***.***> wrote: > I think I found where to do this, I'll work on it this week. >...
Suggestion from @rjbez17: > Alternatively, we could just update the healthz endpoint in this case to tell the control plane we aren't healthy. We could then loop forever in the...