hierarchical-namespaces icon indicating copy to clipboard operation
hierarchical-namespaces copied to clipboard

Inclusive configuration of resources to propagate

Open mzeevi opened this issue 2 years ago • 5 comments

Addresses #16. As suggested in the issue, an additional SyncornizationMode called Allow is added (and not AllowPropagate to allow the kubetcl plugin keep the same logic of converting the strings to Title).

Allow only allows propagation of objects when a selector is set. When a selector is set, Allow follows the same logic as Propagate. When no selectors are set, the object is not propagated.

In addition, an all selector is added.

New unit testing and e2e testing were made for this mode and for the new selector.

The documentation and quickstart testing are left untouched.

mzeevi avatar Jul 24 '22 14:07 mzeevi

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: mzeevi / name: mzeevi (adde9f013e6c8859dd9a0ea9964ca64f5d547992)

Welcome @mzeevi!

It looks like this is your first PR to kubernetes-sigs/hierarchical-namespaces 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hierarchical-namespaces has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Jul 24 '22 14:07 k8s-ci-robot

Hi @mzeevi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jul 24 '22 14:07 k8s-ci-robot

Thanks for the notes, Adrian! I will address everything in a new commit.

mzeevi avatar Aug 14 '22 15:08 mzeevi

I believe I've addressed everything, please take a look @adrianludwin

Thanks!

mzeevi avatar Aug 23 '22 14:08 mzeevi

Should be fine now

mzeevi avatar Aug 23 '22 19:08 mzeevi

Made some changes as per your comments, @adrianludwin

Thanks again!

mzeevi avatar Aug 24 '22 13:08 mzeevi

lgtm after these last changes are made. Ryan, please feel free to approve (or else I'll do it).

/assign @rjbez17

adrianludwin avatar Aug 25 '22 03:08 adrianludwin

Made some changes in accordance to the latest comments

mzeevi avatar Aug 25 '22 08:08 mzeevi

Should be fine now @adrianludwin

mzeevi avatar Aug 29 '22 07:08 mzeevi

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, mzeevi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 29 '22 13:08 k8s-ci-robot