Adrián Javaloy

Thanks god that the tests failed! Reviewing the code I saw a terrible bug when adding rewards. I've changed that and added custom PRNG support when training. Now everything seems...

Thanks for your comments! I strongly agree with you in merging feature_extractor and model in one class. I might have overthought it just because feature_extractor was already there and I...

It's been a month since my last post and I feel like I have to say something. I've been applying the changes of the review but I'm still missing a...

Finally I've applied those requested changes into the old code. The most remarkable change is that, as you suggested, I describe in the abstract two classes: offline model (the former...

Hahaha don't worry, I'm sure you'll do it. I'm quite busy as well. Congratulations for your newborn! :baby:

Thanks for another good review Davis! I've just looked quickly the comments and I agree with what I've read so far. I'm quite busy these days but 'll try to...

I think I've fixed everything so far. Some things that are worth mentioning (skiping documentation changes): * I have removed the thread-safety requirements. It doesn't that useful for those classes...

Hi @sandsmark. This PR is two-year old, as far as I remember I fixed everything that was reviewed, although I am not sure anymore. First, thanks @davisking :) Regarding your...

The "Allow edits from maintainers" option was already selected for me, you should have write access to my branch.

Ok, that is weird, this is what I actually see from my side:  I will try to rebase to my master branch tomorrow, I don't have the git in...