Adriaan Moors

Results 50 comments of Adriaan Moors

> I have ported this to Scala to try to understand the algorithm and potential optimizations (either in our code generation or in OpenJDK itself). ❤️

Not really, which is why I never wrote anything up around this :-) Be aware of the SAMFunction (if memory serves) tree attachment that will mean this tree will not...

Ok, thanks for elaborating, @cunei -- we can work around on our end for now, but this would be good to have eventually.

@theotown, I'm not sure how to update the README -- could you clarify? I started a PR here that has the requested update for index.md: https://github.com/akka/akka-quickstart-scala.g8/compare/issue-61?expand=1

Pragmatically, I should probably make the method non-final again, but at least the code here then needs to be re-copy/pasted... (And we risk regressing again, because they were supposed to...

Seems like that patch fixes the plugin on the latest 2.12.1 nightly https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/924/consoleFull. Didn't check the actual doc output though

I conservatively assigned to 2.14, since this is likely tricky to fix and we're running out of time for 2.13.

+1 on all your points. We should not use `final` as the "API" for omitting outer pointers. There should perhaps be some way to control unintended capture. Spores solve this...

FYI, this relativizing to `(LocalRootProject / baseDirectory)` approach breaks workflows where you use something like [sbt/sbt-sriracha](https://github.com/sbt/sbt-sriracha) to build the equivalent of a monorepo using lots of `ProjectRef`s to link individual...