Support for 2.12.1, overriding instead of copy/pasting

[adriaanm]

The bad news: I broke the plugin in https://github.com/scala/scala/pull/5469

The good news: there's now a hook method that can be overridden without copy/pasting from the compiler code base. Here's a sketch (didn't check javadoc output, but it works for akka): https://github.com/typesafehub/genjavadoc/compare/api-doc-comment?expand=1

The bad news: the API change with the hook method is not in 2.12.0 (it's in 2.12.1-10c609e-nightly, available from "release-temp" at "https://scala-ci.typesafe.com/artifactory/scala-release-temp/")

[adriaanm]

Pragmatically, I should probably make the method non-final again, but at least the code here then needs to be re-copy/pasted... (And we risk regressing again, because they were supposed to be final so that they were tail recursive..)

[adriaanm]

Seems like that patch fixes the plugin on the latest 2.12.1 nightly https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/924/consoleFull. Didn't check the actual doc output though

[lrytz]

And we risk regressing again, because they were supposed to be final so that they were tail recursive..

you could make the method non-final, and have it forward to a separate, final, tail-recursive implementation method