Adriaan Schmidt

Results 25 comments of Adriaan Schmidt

@yarda Any thoughts on this? Do you think a feature like this could be accepted?

### PR updates * Changed scheduler plugin according to https://issues.redhat.com/browse/RHEL-21923 * Added tuning of the default irq affinity * Removed (hopefully) all code that doesn't work on Python2.7 * other...

> > IMHO: > > [dee5d6f](https://github.com/redhat-performance/tuned/commit/dee5d6f63aab46427ade7415babf3c5ef1488c52) - it's OK for merge now > > [aad02c7](https://github.com/redhat-performance/tuned/commit/aad02c76e152bed9aea7a34846a013278db973f8) - tighten the policy (per inline comment) and it's probably OK > > [17b528c](https://github.com/redhat-performance/tuned/commit/17b528c0d2065ff902d6ceb00407569c2a8f2c05) -...

> Thanks. Regarding the second PR I thought it's good enough for the basic functionality and could be improved later. But if you want to do it right +1 from...

Another PR update: * removed the "dynamic" part from this PR, as this is independent and has been moved to #596 * tried to addess most of the review comments...

@yarda @zacikpa to continue the discussion on dynamic creation (and deletion) of plugin instances (originally in #580): I have updated the behavior of `instance_destroy`: * any instance can be destroyed...

> * Automatically move devices, i.e., iterate through all instances and check if any of their devices should be moved to the new instance. Would be possible with `_check_matching_devices`, while...

After some more testing and fixing, I'm now quite happy with the current implementation. However, I'm seeing some potential inconsistencies in the current behavior of the `instance.active` property, where instances...

> Thanks for the update, @adriaan42. > > > Also, I noticed that the code (existing instance_acquire_devices and also my new instance_create and instance_destroy) call methods only available in Hotplug...

@yarda anything missing/blocking this?