Pierrick Charron

icon indicating a website link https://www.adoy.net icon indicating an email [email protected]

icon company AdoY inc. icon location Montréal, QC, CA icon location PHP 8.2 & 8.3 release manager, geek, software developer, solution architect, open source enthusiast

Results 9 comments of Pierrick Charron

Unusued variables

Hi, i'll have a look at how easy it could be to do such a thing and how reliable it would be. The use detector may detect that a use...

Add type hint and/or type comments to getters and setters

Thanks a lot for your contribution. I had a quick look and it looks good at first. I'll have more time to check it again in more details this week....

Phaked nullable return type object will return phaked object

Hi Fred :-) This is because the default answer strategy used is `SmartDefaultAnswer`. I think a good addition would be to add a new `IAnswer` implementation that does what you...

Static methods of a partial mock return NULL

Hi :-) Could you please submit a pull request ? I see that you created a fix on your repo but you need to submit a pull request. Thanks

Static methods of a partial mock return NULL

I added some comments on the code review. I have some concerns with memory usage with the crurent implementation.

Static methods of a partial mock return NULL

My concern with this PR is that with the proposed implementation, every time a partialMock is created, a new class is declared which increase the memory usage and might be...

Static methods of a partial mock return NULL

The problem is that it's a class definition, not a class instance. And PHP will only free this memory when the "request" is finished. So even if your code is...

Change of behavior when calling parent methods statically

I'll have a look at if/how we can configure that

fgetcsv() cause wrong parse on specific UTF-8 BOM encoded CSV

@cmb69 I would also tend to say that it's not a bug. There is a comment in the documentation talking about this behaviour and how to handle the case. Maybe...