Doroszlai, Attila

Results 127 comments of Doroszlai, Attila

@ChenSammi > `TestKeyInputStream` is still timing out: https://github.com/apache/ozone/runs/7883138304?check_suite_focus=true#step:4:3066

> I think it is the catastrophic outcome that is not acceptable to users. I agree and would like to get this fixed. I'm just wondering about the best way....

> Seems `Paths.get()` has been used in many places other than `RadixTree.getLongestPrefix()`. I guess we should fix those places, too.

> @adoroszlai it can be triggered deliberately, a malicious user could be able to crash the system with invalid keyname. Understood. That's why we should fix it. Just not by...

> So are you suggesting that we should remove all the use of "Path", and simply use String to do the work? Exactly. Only for volume/bucket/key name parsing, we can...

> I found some special cases with "~", ".", "..", which needs the help from "Paths" Why do we need any of those for volume/bucket/key names?

@ArafatKhan2198 I think it is good practice to [ensure CI run in one's own fork succeeds, before opening a PR](https://lists.apache.org/thread/24szm50ybx7ww8zklfzls77p4h9q77yy).

Thanks @ArafatKhan2198 for updating the patch. The order of nodes is still "random", the rest looks good.

Note: Although we used to recommend pushing a new commit to re-trigger the tests, Github now allows committers to re-run only the failed jobs. This also prevents the case where...

Thanks @ArafatKhan2198 for the patch, @jojochuang, @sadanand48 for the review.