ozone icon indicating copy to clipboard operation
ozone copied to clipboard

HDDS-6863. Add Group-Id & Ratis-Roles Information for OM UI.

Open ArafatKhan2198 opened this issue 2 years ago • 3 comments

What changes were proposed in this pull request?

Add Group-Id, Current-Node Role & Ratis-Ring information for OM UI.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6863?filter=-1

How was this patch tested?

Tested on docker OM ha env image

For a single node cluster it will print STANDALONE image

ArafatKhan2198 avatar Jun 15 '22 13:06 ArafatKhan2198

@siddhantsangwan @sadanand48 @jojochuang @adoroszlai can you please review this patch !!

ArafatKhan2198 avatar Jun 15 '22 13:06 ArafatKhan2198

@ArafatKhan2198 I think it is good practice to ensure CI run in one's own fork succeeds, before opening a PR.

adoroszlai avatar Jun 15 '22 13:06 adoroszlai

ensure CI run in one's own fork succeeds, before opening a PR

Thanks I was not aware of that !! I will do that next time :)

ArafatKhan2198 avatar Jun 15 '22 13:06 ArafatKhan2198

For future reference, it was be nice to show current term and how long has pasted since the last election. (Useful to know if there was any recent election and whether or not the OMs were unstable)

jojochuang avatar Sep 09 '22 19:09 jojochuang

Thanks @ArafatKhan2198 for updating the patch. The order of nodes is still "random", the rest looks good.

adoroszlai avatar Sep 14 '22 08:09 adoroszlai

@adoroszlai the OM's are now printed in order

ArafatKhan2198 avatar Sep 20 '22 14:09 ArafatKhan2198

Note: Although we used to recommend pushing a new commit to re-trigger the tests, Github now allows committers to re-run only the failed jobs. This also prevents the case where previously passed checks fail in a new run.

adoroszlai avatar Sep 22 '22 19:09 adoroszlai

Thanks @ArafatKhan2198 for the patch, @jojochuang, @sadanand48 for the review.

adoroszlai avatar Sep 28 '22 09:09 adoroszlai