Axel Donath

Results 264 comments of Axel Donath

@QRemy Is this ready to merge from your side? @LauraOlivera Will you have time to work on a follow up PR which actually tests this with real HAWC data?

@registerrier Any final comments from your side?

I think we could even introduce a base class that is common to all objects in Gammapy. So not a mix-in solution but a a single common base class. I...

Thanks @evertrol! Now that the work is done I would propose to just keep it. One of the most important features of Gammapy is interactive use of the objects in...

@registerrier Can you please do the 2nd approval here? Thanks!

Alternatively one could probably just infer it from the existence of certain `MapAxis`?

@AtreyeeS More like `guess_format()`: - If only an energy axis is present -> `format= "gadf-sed"` - If a "time" axis is present -> `format= "lightcurve"` - If a "projected-distance" axis...

Thanks a lot @AtreyeeS! At first glance this looks fairly complete to me. I'll comment again if I find something is missing...

Here is a number of small issues found by @bkhelifi: - https://docs.gammapy.org/0.19/howto.html#access-iact-dl3-data (typo in the link) - https://docs.gammapy.org/0.19/howto.html#extract-1d-spectra (broken link toward the tuto) - https://docs.gammapy.org/0.19/howto.html#model-2d-images (broken link toward `2-dim sky...

As a reminder: `EDispKernel` and `PSFKernel` are not listed in https://docs.gammapy.org/0.19/irf/index.html#classes.