Axel Donath
Axel Donath
https://github.com/gammapy/gammapy/pull/2562
A few more suggestions from my side: - I think we should introduce a general `Map.resample(geom_spatial_coarse, weights=None, ufunc=np.sum)` method, similar to what we have for `Map.resample_axis`, I'll propose a prototype...
@QRemy I'll open a separate PR to implement `Map.resample()`. Then you can rebase this one...
@QRemy I just realize you already implemented the `.resample()`, based on `.fill_by_coord()` and the `preserve_counts`, which is fine. For consistency and easier review please still split the work: - Open...
Thanks @QRemy, there is still one facing unit test: https://github.com/gammapy/gammapy/runs/6195848746?check_suite_focus=true#step:9:4197
@QRemy I realize the `Map.resample()` method was not working as expected: it did not return anything...I proposed a fix in #4085. Once this PR is merged, please rebase this PR...
I think some solution like this should be in place for v1.0, so I put the v1.0 milestone here...
Thanks @vuillaut! What is not clear to me is, whether it make sense to have that as an action that runs on pushing a tag. This basically introduces the change...
@bkhelifi No, I think independent of any version number the script should just always create a new `CITATION.cff` following the policy in PIG 24. Whether the author list is "appended"...
Thanks @vuillaut! I included the release date correction in #4137 as a step to do before a tag. For v1.0 we will not get a fully automatized creation o the...