Adam M

Results 12 comments of Adam M

Bumping this. Nim nightlies are being pre-build for ARM64 (and also ARM7L).

@PMunch Hello, I really enjoyed your NimConf 2021 talk! I agree with @bob-u it would be great to use this with ESP32 devices. ESP32 uses a version of FreeRTOS so...

Tests are failing because of CVE fix not being in Nim v 1.6.0. It works on devel.

> Can we fix the underlying issue instead of stripping the brackets out? I've tried to figure this out but I couldn't find any sqlite function nor anything else which...

Another solution would be changing the SQL code to not use [MATCH](https://www.sqlite.org/lang_expr.html#:~:text=The%20MATCH%20operator%20is%20a%20special%20syntax%20for%20the%20match()%20application%2Ddefined%20function.%20The%20default%20match()%20function%20implementation%20raises%20an%20exception%20and%20is%20not%20really%20useful%20for%20anything.%20But%20extensions%20can%20override%20the%20match()%20function%20with%20more%20helpful%20logic.)? However I am not really a pro in writing SQL queries, so I don't dare to write one...

> > Is it even safe to allow a custom SQL query to be passed in? > > Is that really what's happening here? I see `fastRows` used here which...

I reviewed it again and it seems like MATCH only accepts "AND", "OR", "NOT" / "-" and parentheses as special operators after all and should be faster than LIKE anyway....

Fixing the query by adding parentheses makes the forum (sqlite database) not to error out though. Are you sure it wouldn't be better? I think the search shouldn't error out...

This answers the malformed MATCH expression: https://stackoverflow.com/questions/11708736/sqlite-match-operator

So what should we do? I've already proposed to replace parentheses and also an automatic fix for missing parentheses... We can also just catch a DbError and give no results...