John Adler
John Adler
1. Increase test coverage. 2. Use `rsmt2d_test` package to test all exported methods. 3. Consider using `rsmt2d_test` test package for more of the tests, to not rely on internal methods...
Add a library to the Solidity contracts to handle parsing/concatenating shares. Will be needed potentially by optimistic rollups.
If there are no validator set updates for the unbonding window, the bridge must halt.
- Any necessary fraud proofs - Timeouts required - Honesty assumptions - Failure modes
> I'm fine with merging without that for now. But eventually, this should include some kind of tokio task or executor that drives progress and handles timeouts etc. ([originally posted](https://github.com/FuelLabs/fuel-pbft/pull/1#discussion_r778471177)...
Outdated comment line: https://github.com/FuelLabs/fuel/blob/afee682ddda10a5bb0f6cf4d349f426333464ca0/src/Deposit.yulp#L86 Need to update this line to describe the newer logic, i.e. only one deposit allowed. Thanks to @homakov for noticing.
#105 removes Rosetta tests in CI. Re-add them when the time is right (ideally before incentivized testnet).