John Adler

Results 87 issues of John Adler

In light of the most recent exploit on Nomad (), there's a need to differentiate between default and non-default leaves when querying the contract storage tree. ## Current Design The...

enhancement
comp:FVM

Follow-on on #340

enhancement
comp:FVM

When less than base, the log of a number is negative. Since we don't have negative numbers in the VM, need to specify this case. Noted by @rostyslavtyshko

comp:FVM

Should we leave more spacing between script tx fields and create tx fields? I noticed you left plenty of space between the input, output and witness values, but script tx...

question
comp:FVM

First should be used for function selector, and second should be used as a pointer to data (or perhaps the data directly if it's a copy type, need to double-check).

ABI

Transcluding from https://github.com/FuelLabs/fuel-specs/pull/343 Some considerations around parameter choice: a script that uses 10M gas can have a gas price of ~100B before you have to start worrying about overflow. Assuming...

comp:FVM
comp:VAL

enhancement
comp:VAL

8 and 16 bits are used throughout, but are too small.

comp:VAL

E.g. gas price * gas limit must not overflow. Ref: https://github.com/FuelLabs/fuel-tx/pull/94#discussion_r835689994

bug
comp:VAL

New tx type: 0-input 1-output, can mint up to the fees collected in the block, must be first tx in block Have parameter for maturity period (optional, can be left...