Arseniy Klempner

Results 19 comments of Arseniy Klempner

Is this issue still relevant? Looks like `CounterfactualApp` is already an interface, and all the contracts in `packages/apps` use the `* is CounterfactualApp` pattern

I found that the pattern isn't implemented in one of the `default-apps`, `ETHBalanceRefundApp`. It can't be an instance of `CounterfactualApp` because its implementation of `resolve` reads from state: ``` contracts/default-apps/ETHBalanceRefundApp.sol:24:18:...

> @weboko: Can you help me? Is it "normal" that some of the CI checks fails? I see some peer discovery errors. This change is needed for my PR on...

Moving to icebox. As of now, Status is continuing to use named sharding for the near future so we should not remove it.

An opt-in migration strategy can work here as well. ``` function migrateToken(uint256 tokenId) { require(ERC721(oldERC721Address).ownerOf(tokenId) == msg.sender); require(ERC721(oldERC721Address).takeOwnership(tokenId)); //if there's metadata migrateMetadata(tokenId); require(ERC721(oldERC721Address).transfer(burnAddress, tokenId); _mint(msg.sender, tokenId); } ``` The specifics...

I believe the same is true for `PLCRVoting`

@danisharora099 The reason I made the `shard` field optional is because right now there's no other way for `createEncoder` to differentiate between static sharding and autosharding. e.g. in the test...

Does this change affect the notes example PR? https://github.com/waku-org/js-waku-examples/pull/286

Did some investigating of this issue. Replicated locally and noticed some patterns that lead to connections closed or peers deleted from store: ``` libp2p:connection:outbound:4zjz071714024970277:error could not create new stream for...

I modified connection manager such that it doesn't delete the dial error after a peer is removed. I waited to reach the state where there were no more peers to...