adjabaev
adjabaev
Hi! I was going trough today's commit and came across this https://github.com/DioxusLabs/taffy/blob/main/src/compute/grid/mod.rs#L300 isn't it supposed to be `final_row_counts` ? If not sorry in advance!
@nicoburns done! I'm glad it helps!! 🎉
Do you think it is a good idea keeping Taffy in name of every class (I am asking the question because I feel like java doesn't have as much concise...
> @adjabaev very excited to see this. I'm on vacation (with limited access to computers / internet) atm. But I will definitely review this when I get back. Glad you...
Hi :) I did some changes to how enums work, these are now generated automatically. This is probably something that could go into a meta PR that would help all...
Also clippy doesn't validate but it looks like it isn't due to my code (and it wasn't the case before i wrote it, I tried looking for the reasons but...
It definitely is! Taffy is using the "border-box" value of that property, meanwhile the default is "content-box" (the one that inflates elements based on padding/ border)
Just wanted to link this issue with #223 as both are related to some extent