Adi Shavit
Adi Shavit
Cool. I’ll give it a shot.
Yeah - it isn't as smooth as I had hoped. Some missing includes (e.g. `` for `std::min`) and the Eigen CMake dependency finders are not working well. Also, it needs...
I kinda of gave up after spending too long on this. I may get back to it. But the things I did need to do were: 1. Remove the CMake...
There’s a PR for this. It needs a review and some testing. Will try to get to it.
Thanks for you PR! `doctest` is a drop-in, header only, unit-testing framework. I prefer not make changes (nor maintain) to its drop-in header file. Maybe @onqtam or @Saalvage can comment...
Well, using a star to indicate a bookmark has been in use in browsers for almost 30 years. Trying to educate folks to think about it as a like button...
Indeed, the star is frequently used for scoring or rating. In these cases it is usually one of several (5). TBH, I didn’t make the connection and I still think...
@eszter007 thanks for stating what I said so much clearly! Note that my original request, was rather humble - allow the user to change the icon in the app (settings)....
I think the discussion here is important. It also seems that there is a general agreement that the current star icon is indeed somewhat ambiguous.