Alexander Dinauer

Results 259 comments of Alexander Dinauer

Hello @jeacott1, there was a rewrite of the SDK in 2020. Seems like encoder support for logback got lost in the process. At least I couldn't find any deliberate decision...

@jeacott1 MDC entries should land in the event context (see https://docs.sentry.io/platforms/java/guides/logback/usage/advanced-usage/). You may also convert them to tags (see https://github.com/getsentry/sentry-java/blob/bf18c0d5b0dfc8c1df5a1a6cda33baf1102fbaaf/sentry-samples/sentry-samples-logback/src/main/resources/logback.xml#L9-L22).

@jeacott1 you should be able to have the IP set by the server by explicitly setting the user IP to `{{auto}}`. See https://docs.sentry.io/platforms/java/enriching-events/identify-user/#ip_address Does that not work for you?

Thanks @mustafaakin for raising this. We'll have a chat about this internally and update here once we know more.

@mustafaakin we have a PR up for changing the behaviour. Once the change lands you should see your custom `user` properties show up the same way you are in JS.

@philipphofmann the exact measurements we collect are still in flux but the code around it could be given a high level review regarding its concept.

LGTM! @marandaneto do you want to give this a glance since you've seen multiple DS implementations and may notice if something's different here.

Looks like this can be merged now. @marandaneto should I go ahead an merge?

Hello @nienienienie I'm unable to reproduce the issue. Is this happening only on certain devices?