sentry-java icon indicating copy to clipboard operation
sentry-java copied to clipboard

Add collectors and background service for measurements

Open adinauer opened this issue 2 years ago • 3 comments

:scroll: Description

:bulb: Motivation and Context

:green_heart: How did you test it?

:pencil: Checklist

  • [ ] I reviewed the submitted code
  • [ ] I added tests to verify the changes
  • [ ] I updated the docs if needed
  • [ ] No breaking changes

:crystal_ball: Next steps

adinauer avatar Sep 12 '22 13:09 adinauer

Fails
:no_entry_sign: Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add collectors and background service for measurements ([#2239](https://github.com/getsentry/sentry-java/pull/2239))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by :no_entry_sign: dangerJS against 2f01147c327b51d168dc6e5e042e99dc2d1c19d3

github-actions[bot] avatar Sep 12 '22 13:09 github-actions[bot]

@philipphofmann the exact measurements we collect are still in flux but the code around it could be given a high level review regarding its concept.

adinauer avatar Sep 14 '22 12:09 adinauer

Performance metrics :rocket:

  Plain With Sentry Diff
Startup time 278.02 ms 341.94 ms 63.92 ms
Size 1.74 MiB 2.34 MiB 613.94 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d89dea01bc94d77c82e013014fd7be0541fff62 322.38 ms 350.82 ms 28.45 ms
3d89dea01bc94d77c82e013014fd7be0541fff62 345.59 ms 364.06 ms 18.47 ms

App size

Revision Plain With Sentry Diff
3d89dea01bc94d77c82e013014fd7be0541fff62 1.74 MiB 2.33 MiB 604.92 KiB
3d89dea01bc94d77c82e013014fd7be0541fff62 1.74 MiB 2.33 MiB 604.92 KiB

github-actions[bot] avatar Sep 21 '22 06:09 github-actions[bot]

superseded by #2445

romtsn avatar Jan 09 '23 08:01 romtsn