Adil Ghaffar
Adil Ghaffar
> last request please add some more unit tests to cover the rollback functionatily that was added here. do you mean the rollbacks that defer functions are doing?
> yep that is the general idea to use the mock lib to inject error for example configure the vf flags and see that we have all the right defer...
@dougbtv @SchSeba Kindly check this. If it looks good, can we merge this?
@adrianchiris all comments are addressed. Please check when you get time.
> to me it feels we should: > 1. take the reverse path (call 1 to rename to temp name and move interface to temp NS) > 2. try to...
@adrianchiris please check when you get time.
@adrianchiris did you get time to check this PR?
@zeeke @SchSeba please review this.
> hi @adilGhaffarDev , I need a little clarification on the problem this PR is trying to solve, as I got no answer in #321 and the commit description does...
> c. can we avoid nested `netns.Do(...)` calls? They make the defer call chain very hard to understand. Can we call them sequentially? I have removed nested `netns.Do()` calls. Please...