Adil Ghaffar

Results 101 comments of Adil Ghaffar

/area machineset /area machinedeployment

cc @sbueringer @fabriziopandini @chrischdi This one is ready for review, please check.

/unhold Unholding because kcp pr is merged.

@fabriziopandini @chrischdi sorry for the delay, I was on vacation, and I was not able to address all the comments. But now all comments are addressed please take a look.

> The last findings I could find. As of that lgtm rebased the PR please re lgtm

right now it only has API changes, and the remaining work is in progress, I opened a draft PR so I can get some early inputs. cc @sbueringer

> Before I start to review the implementation, @fabriziopandini @chrischdi @mdbooth @lentzi90 Are we fine with the API and does it cover your use cases? @lentzi90 flag was also for...

> @lentzi90 flag was also for machineset and that is also going to be removed after 1.9, can I add same namingStrategy in MchineDeployments too in this same PR? I...

@fabriziopandini @chrischdi please take a look when you get time.

> @adilGhaffarDev: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests: > Test name Commit Details Required Rerun command >...