Ansgar Dietrichs

Results 14 comments of Ansgar Dietrichs

Thanks, this seems to have been it! I can confirm that using SDL 2.0.20 (they switched the version numbering scheme between 2.0.22 and 2.24.0) I am able to run OpenRA...

I would ideally want to add slot-based excess blob accounting to this PR, but that would mean that `calc_excess_blobs` would have to include some argument like `slots_since_parent`, which would introduce...

@roberto-bayardo I made some more data gas related changes: - updated `DATA_GASPRICE_UPDATE_FRACTION` - updated `DATA_GAS_PER_BLOB` and `MIN_DATA_GASPRICE` - changed `excess_blobs` header field to `excess_data_gas` and adjusted update rules - changed...

> @adietrichs don't see it in the spec, but I assume fees due to data gas are burned rather than go to validator? Ah, yes they are supposed to be...

Set `MIN_DATA_GASPRICE` back to `1` as discussed on https://github.com/ethereum/pm/issues/647 (discussion about final value will be a separate PR). The PR is ready for merge from my side.

I also removed most of the old mempool issues section as proposed by @Inphi and replaced it with a short updated version.

I added a short version of the explanation by @dankrad to the EIP rationale section. The PR is now open and should be ready to be merged.

Regarding the structuring of return data: Our approach here does meaningfully deviate from prior precompile precedent: The bn128 pairing check https://github.com/ethereum/execution-specs/blob/master/src/ethereum/paris/vm/precompiled_contracts/alt_bn128.py#L154 - explicitly returns the `success` value (instead of making...

> That said, it might be best to format the return value according to Solidity ABI encoding? > > > `uint`: `enc(X)` is the big-endian encoding of `X`, padded on...

Already reviewed by @dankrad and @protolambda, merging now.