Alejandro de la Vega

Add statsmodel file name to validator, and main spec

1

Once stats-models v1 is realized, we should add a reference in the main BIDS spec and validator (for file name only)

RF Suggestion: Instance methods vs helper functions

1

Here's a potential suggestion (/discussion/note to self) regarding the complex abstractions in NiMARE: I noticed there are many cases where at a level of abstraction there are instance methods that...

Optimize Correctors with numba

2

Looking into optimizing performance of correctors using numba or by minimizing OOP overhead in the repeated numerical computations

RF Suggestion: Move FWE to FWECorrector

4

I'm trying to determine why the FWE code lives in the `Estimator` class instead of `FWECorrector`. I'm guessing its because the `FWE` code depends on if its a CBMA or...

Allow converting entire NV collections as Datasets

2

https://github.com/neurostuff/NiMARE/blob/c3f26675709048ae9558be6223f5e0f50741c0ca/nimare/io.py#L451 Here you have to specify which contrasts to convert from collections. Would it make sense to also allow "all". As in, if `contrasts`=None, just ingest all candidate images and...

This would allow auto_model to be run without downloading the full images

variables: Add sparse/dense mode for to to_df, and add alternative design matrix API to access sparse variables

3

https://github.com/bids-standard/pybids/blob/f4bf70cccaf85dc65f2b610f448d141c014562d9/bids/variables/collections.py#L610-L620

in my recent PR, i ran into the issue that there was many spots where an invalid model would lead to an ugly crash. i started adding logic to catch...

Jeannette reported that run and scan numbers were not available to the model & transformations.