Adeeb Shihadeh
Adeeb Shihadeh
Dumping notes here as I work on #1197 * longControl.pid -> longControl.accel? * remove all the "openpilot", "controlsd", etc. * carParams.safetyModel should use the int values, needed for interacting with...
Partially reverting https://github.com/commaai/openpilot/pull/31903
`can/tests/` is 20x faster to collect than `car/tests/`. ``` batman:opendbc$ pytest --co can/tests/ ============ 22 tests collected in 0.05s ============ batman:opendbc$ pytest --co car/tests/ ============ 1627 tests collected in 1.04s...
The way openpilot cancels cruise control on most Toyotas has the side effect of a chime from the car and a momentary fault on the dash. When openpilot sends the...
https://github.com/commaai/openpilot/blob/b941b39c56db2d9d7f756cb0949ef6a7cf61774a/selfdrive/car/chrysler/interface.py#L35 controlsd should generically support asymmetric min steer speeds, one for engage and another for disengaging.
For Hyundai and Honda Bosch, we have [a hidden toggle](https://github.com/commaai/openpilot/blob/9eb27259c7b9bf267671b16d17ae9a21b43105f3/selfdrive/ui/qt/offroad/settings.cc#L81) that will allow you to enable long control; make the toggle visible by setting the `DisableRadar_Allow` param. The name doesn't...
The manufacturer platform/generations we use to split cars in openpilot is insufficient for determining lateral control parameters. A list of EPS FW versions is brittle and not scalable, so let's...
Once this is fixed, we can [re-enable it](https://github.com/commaai/openpilot/blob/dad948983a7ff26ffc073c536bd1e99b5d826cec/selfdrive/car/chrysler/interface.py#L16). See commaai/openpilot#26842 for more details > harald > 3:09 PM > I am 60% confident something is messed up with the track...
Due to the rain? There's a couple instances in this route: `977a870d85685a57|2023-03-15--11-00-35`. This may be one of them: https://connect.comma.ai/977a870d85685a57/1678904273720/1678904290463
This Niro EV 23 has SCC_CONTROL on the other side of the relay than the ones we've seen. ``` 66cf8ea23b7c2789|2023-12-05--10-19-33 ```