Adam

Results 5 comments of Adam
trafficstars

when you plan to merge it @hipstersmoothie ?

@KidsDontPlay saturation and desaturation is using external https://www.npmjs.com/package/tinycolor2 lib. It is moving px by px and call it (https://github.com/jimp-dev/jimp/blob/main/packages/plugin-color/src/index.js#L105).

> ![image](https://private-user-images.githubusercontent.com/100900895/328383562-b5f24d6d-4313-4d13-b1b2-a5b0da905dc1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4MTk0MjgsIm5iZiI6MTcxOTgxOTEyOCwicGF0aCI6Ii8xMDA5MDA4OTUvMzI4MzgzNTYyLWI1ZjI0ZDZkLTQzMTMtNGQxMy1iMWIyLWE1YjBkYTkwNWRjMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzAxJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwMVQwNzMyMDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ZDAzZTJjMDBhMWIzNzdiMjA1YjJkODMwOTBhMTljYWExOTA1OTc2Nzg5ZGQ5ZGJkODdmMTM2Yjg3ZTcxM2ViJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.G3MwTg-OFpMpMmXLATbGXNYoa_tgppvAQxC-PlGxuCY) > > I did it. Using random number as key can really impact performance. For React reconciliation algorithm it will be new component on each render and it...

is is not only that there is deprecated punycode dependency, but also security scan shows issue with old version of braces library: `The NPM package `braces`, versions prior to 3.0.3,...

thank you @fasttime !!!