browser-github-release-downloads icon indicating copy to clipboard operation
browser-github-release-downloads copied to clipboard

Fix counter placement with new style

Open aonez opened this issue 3 years ago • 6 comments

Github changed the releases structure. Check the style works properly in your extension.

aonez avatar Jun 26 '22 09:06 aonez

Can confirm this pull request fixes #34

noahbclarkson avatar Jun 30 '22 21:06 noahbclarkson

Thanks for this PR 👍 that does, indeed, restore the downloads count!

When I load https://github.com/ytdl-patched/yt-dlp/releases/tag/2022.07.08.40298 in my browser, this is what I get:

dlc1

i.e. there's a very wide gap between the number of downloads and the DL icon itself... Sadly, I don't master CSS code myself, but upon trial-and-error I found that commenting out https://github.com/addshore/browser-github-release-downloads/blob/03309fdb31337ad1cc0d91e1a4b109ed91293099/app/scripts/contentscript.js#L48

will make it look as below:

dlc2

i.e. much closer to the way it looked before GH's latest, totally uncalled for 😞 , change...

If you asked me, I'd also hope for a CSS "way" to

  1. Align in the same vertical column all the DL icons; when the DL number becomes 2-digit (3-digit, etc.), the DL icon for that number is shifted to the right accordingly...
  2. Do away completely with the newly added, far-right, "20 hours ago" column; it's basically redundant, since that info is already available previously:

dlc3

Vangelis66 avatar Jul 09 '22 00:07 Vangelis66

@Vangelis66 better create an issue for this.

aonez avatar Jul 18 '22 09:07 aonez

Hi could you please update the chrome extension with the patch in the google web store?

surfzoid avatar Sep 22 '22 07:09 surfzoid

after downloading zip from https://github.com/aonez/chrome-github-release-downloads/tree/patch-2 and from chrome extension load unpack ex, i don't see dll count from release

surfzoid avatar Sep 23 '22 05:09 surfzoid

very strange, to be sur i added console.log(el.href); i see correctly the download file in the list from chrome console the var downloadMap have it too, but with also download count.

but never enter in this if : if (el.href in downloadMap) {

surfzoid avatar Sep 23 '22 07:09 surfzoid

Hi could you please update the chrome extension with the patch in the google web store?

Hi, sorry I have been off traveling. Let me take a look at this now!

addshore avatar Jan 16 '23 17:01 addshore

Looks better than nothing! image

addshore avatar Jan 16 '23 17:01 addshore