Andy Brown

Results 14 comments of Andy Brown

> I will go through your pull request and focus on feature duplication and > namespace. The whole set of pull requests looks great, kudos - much better > than...

Ok, finally cleaned up and pushed the commit where I renamed _RasterTextRenderer_ to _TextRenderer_. I'll work on cleaning up the shader loading, but having done that I'm comfortable in saying...

Ok, this doesn't exactly inspire confidence but I ran the the test for TextRenderer that was in there before and realized I introduced a NullPointerException when the user calls setUseVertexArrays...

Ok, fixed the bug with setUseVertexArrays, and one with dispose, too. Cleaned up ShaderLoader a bit, where now we pass it a GL, validate the program, and at least most...

Turns out not so silly... I was sure I saw somewhere that a few of the glPixelStore parameters were only in OpenGL 1.2, so I had a check in there...

@sgothel I merged your master branch in -- I think this should be OK to pull again. Maybe afterwards we can work on moving the package-private utilities to the jogamp...

Relevant output from `git log -- TextRenderer.java`: 1ec82447e464d5308442581f14d32f9775928454 Relocating javax.media.opengl.\* -> com.jogamp.opengl.\* (Part 1) 947bf9c45261013d81cc7199cb71c89b88b18fdf Findbugs: Use static fields where possible a41db57df54863566b0e286cd100bbbc5518eb7f Findbugs: Use NumberType.valueOf(..) instead of 'new NumberType(..)' 96d530e7127c89db9991080e6268c6e8430d0619...

Since I dropped the "debug window" from `TextRenderer` I don't think 7f7a23dd0ddf106e6f0c69fc2a05ff92ac56200e, 8ac3f344aded383ca9a3083a877af7bfdf6e1e48, or 7d7e7c901d8fe54af1230cbf10e568f1a8433cbe apply anymore.

As you might have already noticed I took care of using `GLExtensions` (except for `VERSION_1_1` which isn't there), but should probably check the constants are being accessed directly... Other than...

`RectanglePacker` was the only other conflict, but that was pretty straightforward to merge manually. Basically I had just added a constructor where you could specify the expansion factor.