Adam Dangoor

Results 50 comments of Adam Dangoor

Looking under the hood at how those are retrieved if they are not set by the user we can see `set_node_lists_if_unset`. `set_node_lists_if_unset` makes HTTP requests to `/exhibitor/exhibitor/v1/cluster/list` and `/mesos/slaves`. To...

Just a thought to consider later - maybe this is better as `Cluster.from_master_node` and the user has to construct a `Node` object.

Thank you @jkoelker - this will need a few things, at least: * A test which at least checks that `minidcos docker --version` works in Docker - see `test_admin/test_brew.py` and...

Thank you @RogerWeihrauch - this is on our radar and I will keep this issue updated.

Let's keep this open - I have no timeline but I would like to get to it!

FWIW I also don't know why this is there and it comes from the port of DC/OS Docker - see https://github.com/dcos/dcos-docker/blob/feed8d98a88262b7023c0ed98f454644360318aa/Makefile#L58.

This is the original commit which added the mounting - https://github.com/dcos/dcos-docker/commit/bb568221f55808c03d8fa9821b5eeca3b1d42065. We have no context except the commit message "mount systemd all the things".

The comment by the code is "# Mount cgroups into agents for Mesos DRF." from @timaa2k . Any thoughts on whether removing this would be an issue @jieyu or how...

I removed the mount in https://github.com/dcos/dcos-e2e/pull/1601 - let's see if this comes back to bite us! At least if it does we will know why we had this mount.

When we remove the mount, and do no tinkering, we see the following when attempting to deploy Kafka. ``` Feb 14 15:13:40 dcos-e2e-default-4d773-agent-2 mesos-agent[1873]: E0214 15:13:40.545511 1882 cgroups.cpp:712] Failed to...