dcos-e2e icon indicating copy to clipboard operation
dcos-e2e copied to clipboard

Feature: publish docker image

Open jkoelker opened this issue 5 years ago • 1 comments

In updating marathon-lb to use dcos-e2e, I am running minidcos in a container to minimize dependancies on the host to only docker. The dockerfile I was using (before rolling it all together into the devkit) is: https://github.com/jkoelker/marathon-lb/blob/dcos-e2e-old/Dockerfile.dcos-e2e. It's used as such:

DCOS_E2E_INSTALLERS_DIR=/abs/path/to/installers/on/host \
DCOS_E2E_WORKSPACE_DIR=/abs/path/to/workspace/on/host \
docker run --rm  --tty \
    --volume /var/run/docker.sock:/var/run/docker.sock \
    --volume ${DCOS_E2E_INSTALLERS_DIR}:${DCOS_E2E_INSTALLERS_DIR} \
    --volume ${DCOS_E2E_WORKSPACE_DIR}:${DCOS_E2E_WORKSPACE_DIR}
    dcos-e2e \
        minidcos docker create \
            --workspace-dir ${DCOS_E2E_WORKSPACE_DIR} \
            --wait-for-dcos \
            ${DCOS_E2E_INSTALLERS_DIR}/dcos_generate_config.sh

The important thing to note (at least the way I got it to work) was making the paths the same both inside and outside the container.

jkoelker avatar Jan 03 '19 16:01 jkoelker

Thank you @jkoelker - this will need a few things, at least:

  • A test which at least checks that minidcos docker --version works in Docker - see test_admin/test_brew.py and test_admin/test_binaries.py for inspiration
  • User documentation - how can I use this? why should I use this? what are the limitations?
  • A change to admin/release.py to add publishing a Docker image

adamtheturtle avatar Jan 08 '19 17:01 adamtheturtle