Adam ⚛ Stegman

> Changing the send to read_attribute works. That's really interesting, because `read_attribute` pulls the value from the `@attributes` instance variable, seemingly ignoring your `attr_accessor`. I'm guessing that in this case,...

Yes, you can set `devise.saml_update_resource_hook` to a proc. Use [the default](https://github.com/apokalipto/devise_saml_authenticatable/blob/3934b53af92a4ea91b3d3c266535c020a4b807c9/lib/devise_saml_authenticatable.rb#L96) as a starting point and you can customize from there!

Redirection can be tricky, depending on when you want to do it! The basic flow is something like: - [`Devise::SessionsController#create`](https://github.com/plataformatec/devise/blob/9aa17eec07719a97385dd40fa05c4029983a1cd5/app/controllers/devise/sessions_controller.rb#L19) - [`Devise::Strategies::SamlAuthenticatable#retrieve_resource`](https://github.com/apokalipto/devise_saml_authenticatable/blob/3934b53af92a4ea91b3d3c266535c020a4b807c9/lib/devise_saml_authenticatable/strategy.rb#L48) (via warden) - [`User::authenticate_with_saml`](https://github.com/apokalipto/devise_saml_authenticatable/blob/3934b53af92a4ea91b3d3c266535c020a4b807c9/lib/devise_saml_authenticatable/model.rb#L69) - validate, then create/update...

Great catch! That does sound like the right response.

> i'd love to make a pr but would need some assistance on generating the specs needed to make the specs meaningful for this [ie, specs that fail with the...

Sure, I can add it to the README where it brings up the entity ID reader; or it can be part of your PR if you'd like.

@prosanelli Can you make a new issue and explain more about what issue you're seeing?

Thank you for the contribution! Is there a specific issue in 1.7 or 1.8 such that they should no longer be allowed?

In that case, I don't think we need to require a higher version. Application users can upgrade to a higher version without any issues by running `bundle update ruby-saml`.

@hauserkristen There's nothing blocking application owners from updating, but yes it would be beneficial to update the minimum version of the dependency to help out.