Adam ⚛ Stegman
Adam ⚛ Stegman
1. Why do you have `skip: :saml_authenticatable` in your routes? I'm not sure that's causing the error, but it does seem odd. 2. Have you made any changes to the...
That controller is actually part of the gem, so this is actually a monkey-patch! You should be able to add the code snippet from that wiki page to an initializer.
I saw your comment on #122 and [answered it there](https://github.com/apokalipto/devise_saml_authenticatable/issues/122#issuecomment-436352126), so I'll copy it here: > What I'd like to happen is just redirect the user to a custom controller...
Yeah, I could see this being a sensible option. You could also solve this by setting `saml_attribute_map_resolver` to your own class and reading from a different file.
Great catch! It looks like https://github.com/heartcombo/devise/pull/5462 is looking into this in devise.
Hi @rcamps, there shouldn't be anything in the gem that would be affected by this upgrade. Have you updated your SAML configuration that is passed to the gem? You can...
Can you share your routes file? At least, the parts with `devise_for` and `devise_scope`, and any other authentication routes you have. The output of `bin/rails routes` for those routes would...
I notice that `destroy_user_session` and `destroy_saml_user_session` actually point to the same route. I don't know if that could cause a 404, but it does seem wrong to try to redirect...
I think they should be separate, but that ship has already sailed on v1 of this gem. ☹️
We could do that; it shouldn't be too hard to maintain 1.x and 2.x branches. I think I was hoping to think of more breaking changes that would be helpful...