Adam Sitnik

Results 301 comments of Adam Sitnik
trafficstars

Hello @NinjaCross ! I am fine with the first two points, but when it comes to making `RuntimeInformation` or `AsyncProcessOutputReader` public I would prefer not to do that, as we...

> I would be glad to prepare a PR, if you want. Please go ahead and send the PR, I am happy to review it.

I have added this many years ago, but I was lucky enough to add a comment for future myself: https://github.com/dotnet/BenchmarkDotNet/blob/804482dea148cceaacef0ae341f09d872e640b37/src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliCommand.cs#L218-L219 If .NET 8+ SDK (I don't believe we should add...

I've taken a look at the test implementation and I can't see any reason why it would fail like this (sleep is a native Linux utility, not a .NET command...

```log System.Diagnostics.Tests.ProcessTests.ProcessStart_OnLinux_UsesSpecifiedProgram [FAIL] Assert.Equal() Failure: Strings differ ↓ (pos 0) Expected: "sleep" Actual: ".NET Long Runni" ↑ (pos 0) Stack Trace: /_/src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs(354,0): at System.Diagnostics.Tests.ProcessTests.ProcessStart_OnLinux_UsesSpecifiedProgram() /_/src/mono/System.Private.CoreLib/src/System/Reflection/MethodBaseInvoker.Mono.cs(22,0): at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)...

It seems that it's a new test that has been recently backported to 6.0 in https://github.com/dotnet/runtime/pull/104624 and 8.0 in https://github.com/dotnet/runtime/pull/104623 (cc @bartonjs who has most likely authored it) The failure...

> My problem is that initialization of this collections slows down the whole benchmarking.The collections are initialized 100 and 1000 of times during the benchmark so every second saved counts....