Adam Sitnik

Results 305 comments of Adam Sitnik
trafficstars

@aelij some of the tests are failing, PTAL.

> I'll try to implement it myself if nobody grabs it I am afraid that others might not be able to test this particular case easily. Should I just assign...

The mentioned method (`FileSystem.OpenAppPackageFileAsync`) is part of MAUI. @marek-safar or @terrajobst could you please transfer this issue to https://github.com/dotnet/maui?

We have not touched this area in 6.0, so it must be some kind of rare flakiness. I am moving it to future for now.

@franciscomoloureiro could you please solve the merge conflict?

> Sorry I'm not sure what you mean by "ensuring this health check is optimal"? @kevingosse Currently the health check registers a singleton factory which creates a `DogStatsdService` dedicated to...

I've sent https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/pull/2329 as a follow up

> Any theories, @adamsitnik? The test failed when comparing the lengths of a streams that contained: - serialized `WeakReference` - deserialized and serialized `WeakReference` https://github.com/dotnet/runtime/blob/bec59708182682410afb4014a729149c1cf3439f/src/libraries/System.Resources.Extensions/tests/BinaryFormatTests/FormattedObject/BasicObjectTests.cs#L39-L40 My theory: `WeakReference` was no...

In #105072 I've rooted the target of `WeakReference` by storing it in a static field: https://github.com/dotnet/runtime/blob/a47eeecf12361751b494e83fd49adc9a28969687/src/libraries/System.Resources.Extensions/tests/BinaryFormatTests/Legacy/BinaryFormatterTestData.cs#L55-L58 https://github.com/dotnet/runtime/blob/a47eeecf12361751b494e83fd49adc9a28969687/src/libraries/System.Resources.Extensions/tests/BinaryFormatTests/Legacy/BinaryFormatterTestData.cs#L723 I was expecting that this is going to prevent the GC from feeing...