Adam Sitnik

Results 317 comments of Adam Sitnik

> I think we can obtain full isolation of the benchmarks using AssemblyLoadContext in Core, and AppDomain in Framework We could, but the complexity it would bring would be HUGE....

In the long term we should be investing in having a source-generator toolchain (https://github.com/dotnet/BenchmarkDotNet/issues/1770), that would simply work everywhere except for F# (it's not using Roslyn). The idea is quite...

> Sure, investing in a source generator toolchain is good, but that's not really relevant to this issue. Even if the source generator supports in-process, the assembly still should be...

> don't support launching the process again Then we can make the source generator toolchain start Threads instead of processes. Otherwise we have to maintain few more toolchains and sync...

The bug must me somewhere here: https://github.com/dotnet/BenchmarkDotNet/blob/master/src/BenchmarkDotNet/Running/PowerManagementApplier.cs Please send a PR with a fix

I suspect that the current directory is different and the files get created in a different folder. Could you please see if it's true?

> Any idea why that might be? VS must be setting a different working directory. You can check it by adding following code to your console app: ```cs System.Console.WriteLine(System.Environment.CurrentDirectory); ```...

Hi @aaubry Thank you for the detailed bug report. Would you be interested in sending a PR with a fix? It should be a matter of fixing the `Escape` method...

> Any update on this ?? @postmeback It's still up for grabs. You can fork the repo, create a branch, work on a fix and send a PR. If you...

Hello @bender2k14 > Can this contrast be improved? Yes, but it would require your contribution. The colors are defined [here](https://github.com/dotnet/BenchmarkDotNet/blob/3223c94a92050147a02482a3810860703f0c5171/src/BenchmarkDotNet/Loggers/ConsoleLogger.cs#L64-L75) Please feel free to experiment with them and send a...