BenchmarkDotNet
BenchmarkDotNet copied to clipboard
dotnet
[Bug] Pointless power plan change
You should not change power plant to High Performance if it is already Ultimate Performance.
The bug must me somewhere here: https://github.com/dotnet/BenchmarkDotNet/blob/master/src/BenchmarkDotNet/Running/PowerManagementApplier.cs
Please send a PR with a fix
From the brief look at it I am not seeing the problem, must be in the calling code.
Another thing, what happens when user presses Ctrl+C to interrupt test execution? I don't see the code hooking console event handler to restore power plan when process is interrupted?
Absolutely the whole idea of messing with user settings is IMO bad if you don't guarantee they will be restored.
Another scenario -- Windows Update decides to restart the PC while the benchmark is running. Are you intercepting WM_QUERYENDSESSION to stop shutdown or at least restore power plan there?
Just had to come here and say as someone that just tried this framework the changing of power plans feels very weird. On my laptop I use balanced, yet when running these tests it changes the profile to performance, which increases my screen brightness (I have custom settings I'd like to retain between the different performance profiles). Is there a reason this is done, that performance profiling cannot be done on the user's current power plan?
