Adam Mckaig

Results 32 comments of Adam Mckaig

The failures are mostly deviations from the spec rather than missing features. After fixing the panic and the infinite loop, [here are the failures](https://gist.github.com/adammck/9590540), reformatted a bit for readability. Most...

**Update**: I've fixed everything except for [32 whitespace-related failures](https://gist.github.com/adammck/9611957). Those will be a bit tricky, since Mustache's whitespace rules are pretty weird. I think it would be useful to skip...

I wouldn't be against making acceptsGzip/parseEncodings/parseCoding public, but we should move them to a subpackage if we do so. For the latter two, we might want to consider dropping our...

Great bug report, thanks! It seems reasonable to delay content type sniffing until we either write the gzip encoding header or close without/flush gzipping; I'm not sure why it's in...

Hi! Because I like functional options **so much**, I might personally implement this api as: ```go interface contentTypeMatcher { Matches(contentType string) bool } func ContentTypeMatchers(matchers ... contentTypeMatcher) option { //...

Yes, VMWare is supported. Could you send a gist with a redacted tfstate?

I believe that this is solved by #84. Can @Routhinator or @geri4 please verify?

Thank you! I am surprised that this was not causing a problem with the test. Could you add a test-case to show what has changed?

I tend to use the [`remote-user`](http://docs.ansible.com/ansible/intro_configuration.html#remote-user) setting in my playbooks. It's also possible to use the `-u` command line arg to `ansible-playbook`. It would be nice to be able to...

Sounds like a good idea to me. The [Parser.Attributes](https://github.com/adammck/terraform-inventory/blob/master/parser.go#L90) method currently just returns the attributes from the state file as-is, which is usable but not terribly helpful. It would be...