Adam Mark comments

Results 14 comments of


                                            Adam Mark

Customization options: undefinedResult provider '???', pipeNotFound handler

Thanks for this! I'll check out ASAP.

Potential gotcha with chaining Boolean pipes with 0 as input value

Ah, good catch! This is a problem with the "choose" pipe: ``` choose: function (bool, iffy, elsy) { return !!bool ? iffy : (elsy || ""); }, ``` where `!!0`...

Potential gotcha with chaining Boolean pipes with 0 as input value

On second thought, let me think about whether it makes sense to change this. I might just change the docs to say that the "choose" pipes evaluates truthy/falsy instead of...

Potential gotcha with chaining Boolean pipes with 0 as input value

Makes sense, but since `choose` is the only built-in pipe that evaluates a boolean input, it might be better to simply add an optional "strict" argument to this pipe alone:...

handling {{function|pipe}} like {{function}}

Agree, this would be useful. Let me see what I can do here—if I add another conditional statement, this thing is bound to explode. ;)

Hyperpotamus

Thanks for the nice feedback! I don't actively work on Markup.js anymore, but I'll review this at the earliest opportunity and see if it makes sense to pull into the...

Recursive items aren't iterated

Hm, I doubt it—not easily, anyway. If this is an absolute requirement for you, perhaps try Underscore templates, which allows arbitrary JavaScript. http://underscorejs.org/#template

Variable names with dots

Sorry, not easily. Can you do a simple transform on the data before passing it to the template?

Potential gotcha: backtick expressions seem to be passed as strings

Can I see the code for your custom pipe? Thanks.

Potential gotcha: backtick expressions seem to be passed as strings

Thanks, I'll play with this ASAP. In the meantime, a couple things. First, I've [tested](https://github.com/adammark/Markup.js/blob/master/test/spec/MarkupSpec.js#L1174) the ability to process objects inside backticks. Not sure why moment would break this. Second,...