Adam Tyson
Adam Tyson
Closing in favour of https://github.com/brainglobe/cellfinder/issues/298. I don't think this should end up in the cellfinder CLI
Closing as (partially) resolved - https://github.com/brainglobe/cellfinder/issues/207#issuecomment-1342961568
Now documented at https://brainglobe.info/documentation/brainreg/troubleshooting.html
We could also try to warn users preemptively with something like: - Load data - calculate physical dimensions of the input data - warn user if any dimension is vastly...
Hi @dbirman, thanks for raising this. I think this has two parts: - Preventing this on the atlas generation side - https://github.com/brainglobe/brainglobe-atlasapi/issues/217 - Adding some check on the API side...
Yup definitely needed - https://github.com/brainglobe/cellfinder-core/issues/158 has snuck through.
I thought so: https://github.com/brainglobe/bg-atlasgen/blob/f944baaf69004aca270c29dee50592369969db72/bg_atlasgen/mesh_utils.py#L151-L152
Going to close this as I assume it's been fixed, we haven't seen any issues generating atlases recently. We can reopen if needed.
> Could the GIN repo host a file holding the sizes of all atlases to avoid this issue? Don't see why not. Possibly dumb question though - GIN "knows" how...
I'm amazed that this is the best way we have, but I guess if it works?