Adam McCrea
Adam McCrea
I know it only addresses part of this issue, but #126 will at least ensure that there's no Rails Autoscale cost for the default deploy setup.
Nobody ever talks about their *positive* experiences with Heroku support, so this makes me very happy. 🥳
> Maybe we could have checkboxes in the table rows which show/hide each job type within the graph? And have the graph only show the top 5 by default? https://github.com/mperham/sidekiq/pull/5467/commits/da81f58146fe4d58abe2fa25c47db9c68550fcdc...
After posting those demos above, I realized the unchecked checkboxes looked disabled. That's fixed now.
UX improvements in https://github.com/mperham/sidekiq/pull/5467/commits/9f5a658f0e83f68d0cededfc09b9380dd80e37ff: - The chart now displays seconds instead of milliseconds (matches the data table) - Added a label for the x-axis - Added rounding and labels to...
> Any luck on the vertical deploy marks? Up next!
Deploy marks! Those labels show the first "word" of the mark label, but the full label is shown in the tooltip. Perhaps it's too much to assume the first word...
Bug: With the deploy annotations, the chart y-axis scale is no longer updating based on the selected job types. I'll figure it out tomorrow. https://user-images.githubusercontent.com/372/184244551-7b06c3b6-b505-4e3e-8a72-1a1a3fdb96ce.mp4
> Hard code "smarts" or rely on a convention? I don't have a strong opinion here, but if it were up to me I'd probably say "neither", and remove the...
Here's a quick demo of the UX *without* the label. 