Adam Lazik
Adam Lazik
I think it would be better if https://github.com/theforeman/puppet-foreman_proxy/pull/705 before we start documenting this in order to avoid instructing users to edit config files directly.
I am fine either way.
Code ended up going to 3.13, so feel free to either keep it open until the branching or to close it and then reopen later.
Ah, didn't know that it already existed. Yeah that is perfect.
Additional commits are only temporary for easier edits.
In `users_controller_test.rb` on line 408, I think the test is failing because after the subsequent login the user email becomes blank, which no longer gets evaluated as an error. I...
> In `users_controller_test.rb` on line 408, I think the test is failing because after the subsequent login the user email becomes blank, which no longer gets evaluated as an error....
> Is there a PR planned to update the documentation? For example, this section might need revision: [link](https://github.com/theforeman/foreman-documentation/blob/fe8ae8c710fc0c33fe2b3707454fe5e3dadf4a38/guides/common/modules/con_configuring-external-authentication.adoc?plain=1#L6). Thank you for pointing that out, I will bring it to the...
Looks like there is still error when external user tries to log in without the email. I will have to do some more changes.
@ofedoren thank you for the feedback. I found out that methods in hosts controller allow nil interface type, which seems strange to me. The issue is fixed when I hardcode...