theforeman
Email is no longer required for external users
What changes are you introducing?
This PR drops references to an email address being requested for all external users (such as users from FreeIPA or Active Directory).
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
PR https://github.com/theforeman/foreman/pull/10260 makes email optional for external users.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
This PR removes only one line. I checked the whole repo for any other references to the old workflow but didn't find any.
Checklists
- [x] I am okay with my commits getting squashed when you merge this PR.
- [x] I am familiar with the contributing guidelines.
Please cherry-pick my commits into:
- [ ] Foreman 3.11/Katello 4.13
- [ ] Foreman 3.10/Katello 4.12
- [ ] Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
- [ ] Foreman 3.8/Katello 4.10
- [ ] Foreman 3.7/Katello 4.9 (Satellite 6.14)
- [ ] Foreman 3.6/Katello 4.8
- [ ] Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
- We do not accept PRs for Foreman older than 3.5.
The PR preview for bae99eb83376a756f74a007fb94272a995b7aa36 is available at theforeman-foreman-documentation-preview-pr-3227.surge.sh
The following output files are affected by this PR:
- Installing_Server/index-foreman-deb.html
- Installing_Server/index-foreman-el.html
- Installing_Server/index-katello.html
- Installing_Server/index-orcharhino.html
- Installing_Server/index-satellite.html
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR is just about removing one line so I don't think it really needs style review. I'm adding the style review done label for the lack of a better one.
https://github.com/theforeman/foreman/pull/10260, which this PR depended on, has been merged.
Code ended up going to 3.13, so feel free to either keep it open until the branching or to close it and then reopen later.
Code ended up going to 3.13, so feel free to either keep it open until the branching or to close it and then reopen later.
I think that if we merge to master now, that should be okay. Right? Branch 3.12 already exists for docs so we just need to make sure not to cherry-pick anywhere.