Adam Kewley

Browser crashes (OOM?) when using a custom `ReadableStream`

11

Hi, this library seems very useful for a project I'm working on, which involves downloading extremely large (>10 GB) datasets (with client-side transformations). Skipping the details a bit, my use-case...

Although the members that are affected by this diff (`m_qVersion`, `m_discreteVarVersions`, etc.) are unused in release builds, it is dangerous to conditionally expose them. The reason why is because of...

Hi, This PR adds `getPreviousStepUnweightedYErrorEstimates` into simbody's `Integrator` interface. ## Motivation We would like to improve the performance of OpenSim model simulations. One important factor in a simulation's performance may...

Clang10 /w C++20 error: SimTK indexes: use of overloaded operator '==' is ambiguous

1

I'm compiling a downstream project that uses OpenSim, but (transitively) includes Simbody. Top-level compiler details: ```bash # clang++ Debian clang version 10.0.1-++20200708124224+ef32c611aa2-1~exp1~20200707224822.188 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin #...

Fixed OpenSim::Controller leaking memory whenever it is copied

1

This PR tries to fix a memory leak in `OpenSim::Controller`. The leak occurs when copy-constructing or copy-assigning a `Controller` (or any derived class). It also happens when copying any class...

Fixes a memory leak in `Delp1999Muscle_Deprecated`. The leak is because copy initialization code sets up function pointers that are then overwritten with other stuff, without deleting the first function pointers....

Remove IKMarkerTask defaulted copy ctor

2

Produces warnings in clang13 because it's a pattern that is formally deprecated. See: https://stackoverflow.com/questions/51863588/warning-definition-of-implicit-copy-constructor-is-deprecated --- This change is [](https://reviewable.io/reviews/opensim-org/opensim-core/3232)

Perf-optimized WrapCylinder::_make_spiral_path

4

This is purely a perf change that aims to be a *logically* equivalent implementation, but with a bunch of computation skipped. When I was doing the perf passes on recent...

Segfault when opening an `osim` with unusual socket connections

1

Opening this modified `Rajagopal2015.osim` file: - https://gist.github.com/adamkewley/153f60406472e14b14bde1f507d05fff In OpenSim4.4 will trigger a segfault that causes the whole process to crash. "Whole process" can mean (e.g.) a scripting environment, GUI, or...

Fixes a warning that is emitted by newer versions of clang/gcc, e.g.: ```text /home/adam/opensim-core/dependencies/simbody/Simbody/src/RigidBodyNode_LoneParticle.cpp: In member function ‘virtual const SpatialVec& RBNodeLoneParticle::getHCol(const SBTreePositionCache&, int) const’: /home/adam/opensim-core/dependencies/simbody/Simbody/src/RigidBodyNode_LoneParticle.cpp:414:12: warning: function returns address of...