Adam Franco

Results 60 comments of Adam Franco

Generally I support clean interfaces as these can make it a lot easier to "do the right thing". PSR4 class-naming and namespacing is a great example of this. That said,...

Thanks for getting this started, @ikari7789. I'm pondering the pluses and minuses of going with `\phpCAS\CAS` as the main class or using `\phpCAS\phpCAS`. On the `\phpCAS\phpCAS` side, this could allow...

As noted in #256, PHP 5.6 is reaching EOL in less than a year, so at least the unit tests will need some overhaul that isn't backward-compatible with PHP 5.6...

With a backward-compatibility break it might also be time to investigate what a new public API might look like. #62 touches on this a bit and it probably makes sense...

Hi @jfritschi, Sorry for taking a while to get back to this. I question the utility of turning off validation, since we really want phpCAS to fail with an error...

I disagree with the assumption about static configuration. In my own usage of phpCAS I've run into several cases where this isn't true. For example the Drupal CAS module allows...

> - What do you think about inheriting standard error classes from for example `CAS_OutOfSequenceException` for any standard cases with statically defined error messages like `CAS_OutOfSequenceException_Proxy`? This sounds like a...

I haven't tried the code yet, but in general your branch looks pretty clean. The big question I have is: What is gained by this approach over making use of...

I still haven't had a chance to test this yet, but since it has utility it gets my vote. :-) One thing I would like to see is some documentation...

Ok, so I don't think my comments in your fork linked here automatically. Here they are: - [remove phpCAS session values before destroying session ](https://github.com/chilversc/phpCAS/commit/b400a0a9920c390c4742f302d3eabbb5c28ef2c6#commitcomment-1444275) - I'm unclear as to...